Use Quantified Expressions

[pjljvandelaar]

Dear Developers,

Why don't you use Quantified Expressions at the following locations?

• https://github.com/alire-project/semantic_versioning/blob/cc69201134c0a8d695b767a1fd1bf4fd8f6f3880/src/semantic_versioning-basic.adb#L81-L87

-      for R of VS loop
-         if not Satisfies (V, R) then
-            return False;
-         end if;
-      end loop;
-
-      return True;
+      return (for all R of VS => Satisfies (V, R));

• https://github.com/alire-project/semantic_versioning/blob/cc69201134c0a8d695b767a1fd1bf4fd8f6f3880/src/semantic_versioning-extended.adb#L233-L238

             when Anded =>
                return OK : Boolean := True do
                   Trace ("AND children count:" & Trees.Child_Count (Pos)'Img);
-                  for Child in VS.Set.Iterate_Children (Pos) loop
-                     OK := OK and then Is_In (Child);
-                  end loop;
+                  OK :=
+                    OK
+                    and then
+                    (for all Child in VS.Set.Iterate_Children (Pos) =>
+                       Is_In (Child));
                end return;

Note that further simplifications are still possible ;-)

• https://github.com/alire-project/semantic_versioning/blob/cc69201134c0a8d695b767a1fd1bf4fd8f6f3880/src/semantic_versioning-extended.adb#L241-L246

             when Ored =>
                return OK : Boolean := False do
                   Trace ("OR children count:" & Trees.Child_Count (Pos)'Img);
-                  for Child in VS.Set.Iterate_Children (Pos) loop
-                     OK := OK or else Is_In (Child);
-                  end loop;
+                  OK :=
+                    OK
+                    or else
+                    (for some Child in VS.Set.Iterate_Children (Pos) =>
+                       Is_In (Child));
                end return;

Note that also in this case further simplifications are still possible ;-)

Greetings, Pierre

[mosteo]

Because that code will likely be older than qualified expressions being generally available, or before they entered my mind as a valid possibility :-)