alireza0 / s-ui

An advanced Web Panel • Built for SagerNet/Sing-Box
https://t.me/XrayUI
GNU General Public License v3.0
2.78k stars 441 forks source link

[Bug]: ShadowTLS parameter issues #267

Closed radiumatic closed 2 weeks ago

radiumatic commented 3 months ago

Describe the bug A clear and concise description of what the bug is.

  1. The handshake server port doesn't get added to the configuration
  2. The port value in the "add handshake server" feature gets added to the configuration as str, not int.

To Reproduce Steps to reproduce the behavior:

  1. Create a ShadowTLS inbound and set the handshake server.
  2. Add a shadowsocks server and add it as the detour to the ShadowTLS server.
  3. Create a chain config in either NekoRay or NekoBox and put the ShadowTLS first, then the shadowsocks config.
  4. You can see in the server logs that it tries to connect to [handshake_server]:0 instead of whatever port you specified and the port isn't present in the sing-box config.

Expected behavior A clear and concise description of what you expected to happen.

Ports being added correctly.

Screenshots If applicable, add screenshots to help explain your problem.

Desktop (please complete the following information):

Smartphone (please complete the following information):

Additional context Add any other context about the problem here.

alireza0 commented 2 months ago

Thank you for your report. I will take a look and fix it soon

radiumatic commented 3 weeks ago

I think this is fixed? @alireza0

alireza0 commented 2 weeks ago

It is fixed now. Please build it or wait for next release.