search

alireza0 / x-ui

xray panel supporting multi-protocol multi-user expire day & traffic (Vmess & Vless & Trojan & Shadowsocks)
https://t.me/XrayUI
GNU General Public License v3.0
2.59k stars 429 forks source link

Serious BUG #1338

Open admin8800 opened 3 days ago

admin8800 commented 3 days ago

After multiple tests, it was found that the randomly generated Short ID in the reality protocol may have defects, causing xray to fail to start.

image

pulsarice commented 3 days ago

I've also encountered the same issue and had to manually edit ShortIDs.

admin8800 commented 2 days ago

https://github.com/admin8800/x-ui/commit/8ef71d27fe93ce4a47a739c12e4122c3a02d32d5

@alireza0

repair

alireza0 commented 2 days ago

It is correct and expected behavior. Based on documentation, shortID could be zero length string. It could not make any issue. If there is, then report xray-core

admin8800 commented 2 days ago

It is correct and expected behavior. Based on documentation, shortID could be zero length string. It could not make any issue. If there is, then report xray-core

But there will be a problem that xray cannot start, I can solve this problem after fixing it

may be an xray-core problem.

alireza0 commented 2 days ago

If it does not accept, it should fail immediately. It seems it is a bug in XTLS image

image
pulsarice commented 2 days ago

It's not the empty ones that are causing the problem. Sometimes x-ui creates ShortIDs with length of more than 16. For example x-ui created this list and x-ray failed to start

          "shortIds": [
            "f45f",
            "fde6",
            "e1233edc48",
            "6c17fa509e",
            "0fbd7f",
            "c53853f3ca8359",
            "107a85",
            "d6",
            "1831b37a",
            "f6bf5f3a",
            "40a3",
            "9921534e2f2c",
            "",
            "918d7172bf39",
            "a46eae9ef3",
            "6c2b9c",
            "defe0c15fa24",
            "6f7e61b6832c",
            "d5abc86d3ccf",
            "0c4230d4a18cac81",
            "92ed57975b0c",
            "d107b2189605493559",  // This one is 18 chars long
            "e0234f5f89",
            "d818a9a9f4"
          ],

editing that single line solved the x-ray start problem.