Closed trentbitterman closed 6 months ago
One other piece of information that may be useful to know. When we upgraded our redis cluster to 7.1.0 all existing connections continued working. They were able to reconnect to the newer version without issue as the new nodes came up. Only brand-new connections that were created after the upgraded experienced this issue.
Let me know if there's any testing I can do in my environment that would be useful. I'm happy to help in any way possible.
@trentbitterman I'll try to setup the environment myself to debug this - however, if it is trivially easy for you to create a throw away test environment for me for a short duration, I wouldn't complain :)
Managed to reproduce it - and though the error handling / exception message still need to be improved, this 1be7935547fedaaefb9337d38a08130d73ffe26c fixes it in master.
If you could give that a quick try I can do a quick release.
Great, thanks @alisaifee! I'll give it a try and let you know.
@alisaifee I tried that new version in my environment and no longer ran into this issue. Thanks for fixing it!
Unfortunately I'm having some issues with clearing CI but will hopefully have a dot release by EOD.
Sounds good, thanks again!
Awesome, thanks!
Expected Behaviour
Initializing a
RedisCluster
object usingRedisCluster.from_url
followed by calling theinitialize
method on theRedisCluster
object should result in a successful connection to the Redis cluster.Current Behaviour
The initialization fails with the following error message:
Steps to Reproduce
Your Environment
This issue started appearing after upgrading our Redis cluster to version 7.1.0. We were previously using version 6.2.6. Other than the cluster version upgrade, no other configuration changes were made in either the cluster or our clients.
I verified myself that the upgrade cluster does in fact support the
HELLO
command by communicating with it directly. This was the output I got:I compared that output to running the same command against another Redis cluster of ours that we haven't upgraded yet and received the exact same response, aside from the version and id differing.
That error message seems to be triggered when and
UnknownCommandError
is raised. Looking through the source I couldn't find any other commands that seemed like they would result in anUnknownCommandError
in any of our clusters. I did seeCLUSTER SLOTS
was deprecated in Redis 7.0.0, but I still got a valid response when I tried it.Here's the full stacktrace we see. Please let me know if there's any other information I can provide that would help. Thanks!
One other piece of information that might be helpful. I also tried setting up the client with
protocol_version
set to2
, as the error message suggested, and the client seemed to connect correctly.