search

alisaifee / coredis

coredis is an async redis client for python with support for redis cluster & sentinel.
http://coredis.readthedocs.io/en/latest/
MIT License
78 stars 11 forks source link

Redict/Valkey support? #226

Closed coandco closed 6 months ago

coandco commented 7 months ago

Given the recent flap about Redis changing its license to one that doesn't meet the definition of open source software, do you plan to support either of the two major forks of Redis (Redict/Valkey) in coredis?

Feel free to close this if it's too off-topic -- I'm just curious what your thoughts are.

alisaifee commented 7 months ago

@coandco - completely open to it - I think the first step would be to add these to the CI compatibility matrix.

I have something like this for keydb & dragonflydb as well

alisaifee commented 6 months ago

Just added valkey to the CI and it mostly behaves as expected: https://github.com/alisaifee/coredis/actions/runs/8767165485/job/24060116715

alisaifee commented 6 months ago

Both redict and valkey are now tested against in the CI. Let me know if there's something else specific that you had in mind?

coandco commented 6 months ago

I think that's it. Mostly it'll be good to know what the support level is if we end up moving to one of the open-source forks.