Closed penguinpee closed 11 months ago
All modified lines are covered by tests :white_check_mark:
Comparison is base (
ada96bb
) 96.58% compared to head (ba93be6
) 96.59%.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Python 3.7 support was actually dropped recently so the conditional import & dependency could just be removed altogether
Python 3.7 support was actually dropped recently so the conditional import & dependency could just be removed altogether
That's up to you, really. In Fedora all currently supported releases are Python >= 3.11.
Removing it, though, will break older Python releases. Whereas the patch, as is, is backward compatible.
Closing in favor of d9a8fba0616f6736c845a156e669b7d1e13cbd86
Actually it looks like importlib.resources.files
is only available in python 3.9 and conditionally handling that in code is more effort than I think it's worth. Once python 3.8 is EOL I can remove this.
importlib.resources
is part of the Python standard library since Python 3.7:https://docs.python.org/3/library/importlib.resources.html
Make sure limits is compatible with Python >= 3.7.