search

alisaifee / limits

Rate limiting using various strategies and storage backends such as redis & memcached
https://limits.readthedocs.org
MIT License
423 stars 59 forks source link

Move to use redis instead of coredis #210

Open hxyannay opened 7 months ago

hxyannay commented 7 months ago

Hey. I was reading the docs and saw that the library uses coredis for the async usage of redis. I assume that this is due to lacking support for asyncio in redis when it was developed.

However, the official library for redis is much more maintained and is the more logical library to use, and by now it has full support for asyncio.

Are you open to the idea of moving to use the official library instead of coredis? If so I can try to open a PR myself for that.

Thanks!

alisaifee commented 6 months ago

I'm open to the idea if it can be done in a backward compatible way

tuukkamustonen commented 4 months ago

Would it be "just" re-writing https://github.com/alisaifee/limits/blob/master/limits/aio/storage/redis.py using redis? Do you foresee some issues there, @alisaifee?