search

alisamar / react-icons-all-files

Other
9 stars 1 forks source link

Upgrade to 4.8.0? Thank you #2

Closed sebastienbarre closed 1 year ago

sebastienbarre commented 1 year ago

Once again, thank for your work exposing all icons in one package. This is very helpful.

Would you consider upgrading your package from 4.5.1 to the recently released 4.8.0? https://github.com/react-icons/react-icons/releases/tag/v4.8.0

Thank you very much

alisamar commented 1 year ago

Thank you for your interest @sebastienbarre, the missing versions have been released.

sebastienbarre commented 1 year ago

Thanks. I appreciate.

However I noticed that your release 4.8.0 notes are not the same as the official 4.8.0 release notes.

For example, your 4.8.0 lists Heroicons 2 at version 2.0.8 while the official 4.8.0 lists Heroicons 2 at the much newer version 2.0.16. It could be just a copy/paste mistake, but I can't tell because the directories are so large. Could you confirm Heroicons2 is at 2.0.16 in your 4.8.0, like the official 4.8.0? I use icons from different collections, but mostly from Heroicons, hence my interest.

Thank you

alisamar commented 1 year ago

Thank you for skillfully rectifying this mistake. Seems like an issue with the readme file. Version 2.0.8 has 530 icons, whereas version 4.8.0 has 584 icons in the hi2 folder. It's likely a typo error. I can confirm this for Heroicons2. Additionally, I'll review other icon packages to ensure they match the official 4.8.0 version.

Thank you.