search

alisamar / react-icons-all-files

Other
9 stars 1 forks source link

Upgrade to 5.1.0? Thank you #4

Open sebastienbarre opened 4 months ago

sebastienbarre commented 4 months ago

It's me again, and again :) Thank for your work exposing all icons in one package. This is very helpful, as always.

Would you consider upgrading your package from 4.11.0 (Sep 6, 2023) to the recently released 5.1.0? https://github.com/react-icons/react-icons/releases/tag/v5.1.0

Thank you very much

alisamar commented 4 months ago

Hey Sebastian, It's good to hear from you again! 😊

I just wanted to let you know that I've finished updating the missing versions. Please take a look and let me know if you run into any issues. Thank you.

sebastienbarre commented 3 months ago

Works great per usual, much appreciated

sebastienbarre commented 3 months ago

Ugh, I'm very sorry, it's only after opening the Console that I realized there is a bug in the 5.1.0 release.

This is unfortunate.

https://github.com/react-icons/react-icons/issues/931

If you don't mind I'll ping you when the 5.1.1 release is out with the fix. I apologize for the work you had to do on this already, I usually wait for a bit before asking, and this apparently had not been fixed in the past 2 weeks.

alisamar commented 3 months ago

Don't sweat it, Sebastian! I'm on it 👨‍💻 The new version with the bug fix will be out as soon as it's ready (hopefully tomorrow!). I've got a notification set up, but feel free to reach out if I miss anything.

sebastienbarre commented 3 months ago

5.2.0 is out :) https://github.com/react-icons/react-icons/releases/tag/v5.2.0 with the fix https://github.com/react-icons/react-icons/pull/936 Thanks

alisamar commented 3 months ago

Hey Sebastien, pushing the new version live now! Thanks for the heads-up, feeling good about this one 😄 Let me know if anything comes up. Thanks

sebastienbarre commented 3 months ago

Thanks.

Alright, the sad news is that it's still broken, it seems React Icons is having some quality issues lately. See https://github.com/react-icons/react-icons/issues/819

Might be time for me to find a new avenue.

alisamar commented 3 months ago

hey Sebastien, I totally agree with you. We've been encountering challenges with React Icons for some time now due to the significant increase in bundle size and the sheer number of files included in the package. With over 145,000 files encompassing TypeScript type definitions and module files, it's become increasingly difficult to manage and maintain efficient deployment builds. Please let me know if you find a new solution. Thank you.

sebastienbarre commented 3 months ago

Consistency when it comes to icons is always a good thing within the same app. We started our app with Heroicons years ago since we were using Tailwind CSS already, then added missing icons from React Icons. Over time I noticed me picking our new icons from Tabler Icons almost exclusively, as it became clear that it was growing much faster than Heroicons itself. With 5,200+ icons, it is now almost 6 times larger than Heroicons, so I took a couple of hours to switch our old Heroicons icons to their equivalent in Tabler Icons, then removed our dependency to React Icons and Heroicons in favor of using Tabler Icons package directly. We only have about 190 icons, but it looks cleaner overall.

Thanks for all the work!

alisamar commented 3 months ago

I really like the move to Tabler Icons! It creates a more consistent look for the app, and managing a single icon set is much easier. Great decision, Sebastien! I will consider this for our apps as well. Keep up the good work, Thank you.