Feedback on First Submission

[Anisha7]

Great job on working on the challenges! Here are a couple of improvements you can make for full credit:

• Strings
  • Refactoring: Contains, find_index, and find_all_indexes all have a lot of overlapping code. Think about how you can break this apart into helper functions OR implement functions by calling one of the required functions, such that there is no repeated code in your file.
  • Add a couple of unit tests for better testing! It is easier than you would think. Look through the unit test file Alan gave, and use that pattern to call your functions on some edge case inputs.
  • Annotate your functions for time and space complexity. What’s the big O? How much space are you using (Are you initializing a new list, new variables, etc.)?
• LinkedList length method: Although this is not required, it would be good to think about how you can improve the time complexity of this function, now that you have a size property that tracks the number of elements in your list. Can it be faster?
• LinkedList insert at index and replace methods currently do not pass all unit tests. Try to debug, use print statements, to see what's going on.

Feel free to come to office hours or reach out if you need help with any of these!

[alishalabi]

Reviewed #2/#3 with Ansel during office hours. Still need to do number #1.

[alishalabi]

Added test suite for #1, added time complexity