Feedback on the second submission

[Anisha7]

• Your imports don’t work! Make sure your tests pass before submitting. I recommend having modules in the same file, or look into why the imports are not working. (A lot of strange import errors with all of the files!)
• You are facing a logical error in your sets class! When you initialize a new set inside your union/intersection/other functions, you are not passing in any parameters. However, your Set class requires a max_size to be specified upon initialization! Either make that optional, or use it. This might have all your tests pass if the functions are implemented correctly. :)
• Your set class should also allow users to have the “option” of adding a list of items during initialization —> s = Set(5, [“apple”, “orange”]).
• Your set should not have a limit for how many elements can be added. It can use max size to initialize/resize the underlying hash table, but you should be able to add as many elements as you want, unless that element already exists (no duplicates). Look over your add method.

[alishalabi]

Fixed imports (removed folder structure, all imports now occurring at root level). Fixed max_size property (removed) - changed all tests, passing all tests. Added option to pass in array of items in setup.

[Anisha7]

A couple more improvements:

• Uncomment the code block in your difference function for it to work correctly! A difference function has all of the elements that are not common between the two sets. If set A has “apple” and set B does not, then “apple” is part of the difference set. In addition, if set B has “yellow” and set A does not, then “yellow” should also be in the difference set. I see that you implemented this, but then commented half of it out.
• Your is_subset function is not working correctly. Add more tests to robustly test this function! There are no tests that check for a True return from is_subset. Try: ht = Set(["apple", "orange", "banana", 5, 15, 43, "hey", "yo", "52"]) t = Set(["apple", "orange", "banana"]) assert not ht.is_subset(t) `assert t.is_subset(ht)``
• Add some tests for set’s size property!