Feedback on Strings.py (First Submission)

alishalabi / CS-1.3

Repo for CS 1.3: Core Data Structures & Algorithms

0 stars 0 forks source link

Open Anisha7 opened 5 years ago

Anisha7 commented 5 years ago

Strings: refactor your code such that there is no duplicate code in the file. Is there a way you could use 1 of the three functions and use them in the other two for the same result? Or use a helper function?
I see that you annotated for time complexity. Do the same for space complexity. How much space is your function using? Are you allocating any arrays, sets, dictionaries, etc?

Anisha7 commented 5 years ago

Could you refactor find_all_indexes/find_index to not have any duplicate code amongst each other?