Add other options - Githubissues

felipemfp commented 7 years ago

What about add other options like port or force https?

alisonmonteiro commented 7 years ago

@felipemfp great!

I think it's ok and all, but do you think that something like this:

generateUrl('google.com/search', { q: 'hi' }, {
  port: 8181,
  https: true
});

Is better than this?

generateUrl('https://google.com/search:8181', { q: 'hi' })

If you got a good way to organize the parameters, please let me know

felipemfp commented 7 years ago

The last option is better indeed, but look a case when you have to generate a url with details that you do not have, for example:

you know the domain, but your UI will ask for a user if it is https or not, so you'll have to write a function that format the URL before call generateUrl.

alisonmonteiro commented 7 years ago

@felipemfp ok, I see.

I will think about this and try to create a structure for this API. Any thoughts?

ValchanOficial commented 8 months ago

Hello, I think there is something wrong, I am not from GitHub Recruitment Team

Sincerely, Valéria Padilha de Vargas.

Em terça-feira, 20 de fevereiro de 2024 às 14:16:14 BRT, Github Notification ***@***.***> escreveu:

Hello,

We have an exciting opportunity for you! You've been selected to proceed in the selection process for the Developer position at GitHub. Congratulations on your achievement!

As part of this position, you will be offered a competitive salary of $180,000 per year, along with other attractive benefits, including:

Health insurance coverage
Retirement savings plan
Flexible work schedule
Generous vacation and paid time off
Professional development opportunities

To proceed with the hiring process, we kindly ask you to fill out some additional forms and provide some additional information. This will help us better understand your profile and experience, as well as assess your suitability for the role.

Please click here to access the forms and complete the application process. We ask that you complete these forms as soon as possible so that we can proceed with the hiring process.

Important: You have 24 hours to complete the application process.

If you have any questions or need further information, please don't hesitate to contact us.

Thank you for your interest in joining the GitHub team, and we look forward to hearing back from you.

Best regards, GitHub Recruitment Team brucelourenco, @fcv, @arturgamma, @horefice, @rsarai, @vadolasi, @moisesmartins-dev, @WelisonR, @romeubertho, @lucas-dev3, @wevtimoteo, @bvieira10, @matheusportela, @brenordr, @krolow, @eudocerrado, @ValchanOficial, @leopiccionia, @JhonatanVicentini, @liviasilvasantos

— Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you were mentioned.Message ID: @.***>