search

alisonthemonster / Presently

Android app for recording gratitude journal entries -- over 1 million installs, contribute today!
388 stars 81 forks source link

Refactor to replace milestones set with isMilestone function #252

Closed jayeclark closed 2 years ago

jayeclark commented 2 years ago

Signed-off-by: Jay Clark jay@jayeclark.dev

:scroll: Description

Fixes #251. Removes milestone set definition and replaces with an isMilestone function that evaluates whether a given integer is 5, 10, or a multiple of 25.

:green_heart: How did you test it?

Existing unit tests.

NOTE: I'm unsure how to address the CI failure as it's not related to my code changes, and if I update the code to include a boilerplate local.properties file to get it to pass the tests, that change definitely shouldn't be merged into the original repo as it will have a nonsense value in it for DROPBOX_KEY.

:camera_flash: Screenshots / GIFs

Not applicable.

alisonthemonster commented 2 years ago

Hi Jay! Sorry about the CI failure, I'm seeing if I can get a fix for that now!

Thank you for the contribution and for your patience!

presently-bot commented 2 years ago

Alright I've fixed the CI issue, would you mind merging or rebasing with develop? Thank you so much and sorry for the hiccup!

alisonthemonster commented 2 years ago

Thank you for rebasing and for fixing this bug! We'll get this out in our next release :)

jayeclark commented 2 years ago

Glad to help!!