Fix Issue: Languages text not visible on 'Emilia' theme #269

[anettleship]

:scroll: Description

Fix for this issue #269 where the languages text is not visible in 'Emilia' theme.

Added fix for this issue #271 where Import CSV Alert Dialog test is not visible in 'Emilia' theme.

To contrast against the background colour for the language menu set by 'timelineBackgroundColor', I have aligned the text colour to use 'timelineBodyColor' from the the active theme for the language menu, instead of 'entryBodyColor'.

This involves an edit to CustomListPrefDialogFragCompat.kt

This also fixes the same text issue which is present in the First Day of the Week dialog (see screenshots).

I've added a second edit to address the issue with the Import CSV Alert Dialog, making changes to styles.xml where the AlertDialogTheme is set, again changing 'entryBodyColor' to 'timelineBodyColor' for the textColorPrimary and textColor Values, as well as the PositiveButtonStyle defined in the same section.

:green_heart: How did you test it?

Manual test in Android Studio Emulator and on a Physical Pixel 6a.

Value comparison of the colour numbers set for 'entryBodyColor' and 'timelineBodyColor' in each theme in colors.xml.

The only theme affected other than Emilia, is Calm, which has very slightly different shades of text set by 'entryBodyColor' and 'timelineBodyColor'. See screenshots below.

:camera_flash: Screenshots / GIFs

Emilia Before:

Emilia After:

Calm Before:

Calm After:

Betsy Before (No Change):

Betsy After (No Change):

Emilia First Day of the Week, Before:

Emilia First Day of the Week, After:

Emilia Import Dialogue Before:

Emilia Import Dialogue After:

Calm Import Dialogue Before:

Calm Import Dialogue After:

Betsy Import Dialogue Before (No Change):

Betsy Import Dialogue After (No Change):

[anettleship]

Minor issue, I can see the Type Face in my development copy of the app does not match the typeface of the production app. I assume this is because I forked from the develop branch rather than the production branch, but I want to call this out incase something else is happening!

[anettleship]

I've edited the original pull request to add a fix for the Import CSV dialog issue.

[alisonthemonster]

Thank you so much @anettleship for investigating this and taking the time to fix and verify across so many themes! I just kicked off CI and when that goes green I'll merge 😄

Thank you again!

[anettleship]

Excellent, really pleased to be able to contribute, thanks!