search

alisonthemonster / Presently

Android app for recording gratitude journal entries -- over 1 million installs, contribute today!
388 stars 81 forks source link

Import Dialog Text not visible in Emilia Theme #271

Open anettleship opened 1 year ago

anettleship commented 1 year ago

The text is not visible in the Import Dialog in Emilia Theme.

This has the same root cause as this issue - Emilia is the only theme that has tonal opposites for Entry Text and Timeline Text, so where an app dialogue uses e.g. EntryText Colours for the Text Body, but TimelineBackground Colours for the Text Background, other themes display correctly, but Emilia does not.

The fix implemented in this pull request does not fix the Import CSV bug.

212567634-7d71374f-a452-46ef-a128-6ce5ea092b20

anettleship commented 1 year ago

The import csv AlertDialog is implemented here.

It should alert the user about overwriting their journal history, and when rendered correctly, has text as follows:

Screenshot 2023-01-23 at 22 25 14

anettleship commented 1 year ago

I've included a fix for this issue in this pull request.

alchemiker commented 10 months ago

Any updates on this issue? I installed the app 5 days ago and after intuitively picking the Emilia theme I also ran into this issue with dialog texts in the settings not showing, so the bug still persists...

anettleship commented 10 months ago

Hello, I can see this change is merged into the develop branch, on the 24th January 2023, however when I look at the app info in the android play store, it looks like the last release is prior to the merge: Updated on 15th Jan 2023. I think we'll need to wait for the next release before we see the change reflect in the live app.

Screenshot_20240106-135242