search

alist / domoapis

0 stars 0 forks source link

Read production mail config from env #6

Closed shirish87 closed 10 years ago

shirish87 commented 10 years ago

@alist, Two issues:

  1. For development: I don't think e-mail notifications are currently working. I recently moved my domain's MX to Windows Live (cuz its free), so this contains the updated credentials. Might want to consider using some @domo.io account.
  2. For prod: Mail (and other) config should come from environment vars. module.exports.mail.production shows how any config value can be read from the environment.
harishnk commented 10 years ago

@shirish87 - will be moving email to sendgrid. Will update credentials accordingly.

Harish Kamath hnk.im | me@hnk.im

On Mon, Dec 23, 2013 at 4:30 AM, Shirish Kamath notifications@github.comwrote:

@alist https://github.com/alist, Two issues:

  1. For development: I don't think e-mail notifications are currently working. I recently moved my domain's MX to Windows Live (cuz its free), so this contains the updated credentials. Might want to consider using some @ domo.io account.
  2. For prod: Mail (and other) config should come from environment vars. module.exports.mail.production shows how any config value can be read

from the environment.

You can merge this Pull Request by running

git pull https://github.com/shirish87/domoapis master

Or view, comment on, or merge it at:

https://github.com/alist/domoapis/pull/6 Commit Summary

  • Working dev mail config
  • Prod mail config to read from env

File Changes

Patch Links: