search

alistair23 / meta-pine64

OpenEmbedded/Yocto layer for the Pine64 boards
MIT License
22 stars 21 forks source link

Thud compatability #4

Closed rbdavison closed 4 years ago

rbdavison commented 4 years ago

Slight modifications to allow building against the thud branch

alistair23 commented 4 years ago

Thanks for the PR!

I added some comments, I don't think removing support for warrior/master is a good idea. Improving the thud support is probably worth doing.

The best option actually might be to create a thud branch, apply these patches to that and maintain a master and a thud branch. Would that work for you?

rbdavison commented 4 years ago

The of the PR was to add the thud branch and update it so that it works. If use the thud branch of bitbake and openembedded-core then the build fails.

In my case I want to include meta-mono and this fails with master and warrior and pointing to master is unstable.

Note I don't want this to be added to master but to create a thud branch on the origin repo. The thud branch would then support thud for the other OE meta repos.

alistair23 commented 4 years ago

I have created a thud branch. Can you re-target this PR against that branch?

alistair23 commented 4 years ago

Ah, I can re-target it. All done.

rbdavison commented 4 years ago

Awesome thank you, Thanks for the great work so far. Your work got me going and I'm grateful that I could assist in a tiny way.

alistair23 commented 4 years ago

No worries. Always feel free to send a PR!

I'm glad people are using this layer. Let me know if it's missing anything.