Closed DavidBuchanan314 closed 3 years ago
Thanks! I'll happily adopt that. (Or send me a PR if you want your name on the commit :) ) As far as I'm concerned it can stay GPL'd - shouldn't be an issue as it's separate from the rest of the code.
At some point I'll tag a v0.1 release so that it doesn't have to hang off a random commit.
nice
@alistair7 I'm too lazy to PR, feel free to manually merge it :)
@DavidBuchanan314 thanks a lot for the PKGBUILD. I see that you did not add it to AUR. Any reason why?
IMHO the PKGBUILD would sit better in AUR than here in the project repo. Better keep packaging de-coupled from the source code, as done virtually everywhere.
@alistair7 I see that you're maintaining the PKGBUILD (e.g. 0ec7c482b248c1bcea12b574e1f0838a0afe5bec). As such, could you please add it to AUR? That would make it much easier to install and keep up-to-date, as we can then use an AUR helper.
You could add both a versioned package (imlib2-jxl
) and a git one (imlib2-jxl-git
).
I was thinking about adding them to AUR myself but I guess it would be counterproductive as you're maintaining the PKGBUILD.
I am accidentally maintaining a PKGBUILD, and I agree that AUR is where it belongs. So with the small caveat that I don't really know what I'm doing, I'll add a package there.
Nice. Thanks @alistair7 !
IMO you should remove the PKGBUILD from the source code once in AUR.
It should be easy for you to put them in AUR. The current PKGBUILDs require just a few modifications. E.g.:
pkgver
for the imlib2-jxl
package is just the version number, e.g. 0.1.1
. Currently it adds the git revision in there too.imlib2-jxl
here, to download the Gziped sources instead of using git. That way they do not depend on git.You'll find loads of examples in AUR itself and in the Arch Wiki docs. If you would like to, I can review the PKGBUILDs, for instance once you push the first version to AUR.
I wrote the following PKGBUILD to make installation easier on Arch:
I based this off a GPL-licensed template. To be honest, I'm not sure the GPL license really matters for such a trivial file - if you wanted to relicense it, I personally wouldn't mind. Consider my modifications to the template to be permissively licensed.