search

alisw / alidist

Recipes to build ALICE software
30 stars 167 forks source link

Update Upcgen recipe #5695

Closed nburmaso closed 2 days ago

nburmaso commented 1 week ago

A small change to update recipe to the latest Upcgen version

@pbuehler, please take a look

Cheers, Nazar

pbuehler commented 1 week ago

Hi @ktf, can you please approve this PR?

ktf commented 1 week ago

@pbuehler Can you please add the package to the CODEOWNERS file, adding yourself as responsible for it?

pbuehler commented 1 week ago

Hi @nburmaso please see previous comment by @ktf. Can you please take care?

nburmaso commented 1 week ago

Hi @nburmaso please see previous comment by @ktf. Can you please take care?

Hi @pbuehler, @ktf,

I have added the line

upcgen* @nburmaso @pbuehler

but me and Paul have no write access for alidist repository -- is it ok?

ktf commented 1 week ago

I guess it's @alisw/pagmc?

nburmaso commented 1 week ago

I guess it's @alisw/pagmc?

I have changed owners to @alisw/pagmc and requested membership

nburmaso commented 6 days ago

Hi @ktf, @pbuehler,

I have fixed quotes and module generation, should be ok now.

Cheers, Nazar

jackal1-66 commented 4 days ago

Hi @nburmaso, I see that you have two new tags in the alice fork of upcgen which are not present in the original repository. Did you simply tweak something in the older version to make it compile in our framework? I ask you because in that case there is a guideline on how to choose the tag name: if the new tag is an offspring of tag-24-06-22 only for ALICE use, then it should be called tag-24-06-22-alice1. Let me know if this is the case. If so I would ask you to make the modification before merging. The CI tests are not so useful in this PR because upcgen is not a requirement of O2 or AliGenerators so it won't be built.

nburmaso commented 4 days ago

Hi @nburmaso, I see that you have two new tags in the alice fork of upcgen which are not present in the original repository. Did you simply tweak something in the older version to make it compile in our framework? I ask you because in that case there is a guideline on how to choose the tag name: if the new tag is an offspring of tag-24-06-22 only for ALICE use, then it should be called tag-24-06-22-alice1. Let me know if this is the case. If so I would ask you to make the modification before merging. The CI tests are not so useful in this PR because upcgen is not a requirement of O2 or AliGenenerators so it won't be built.

Hi @jackal1-66,

The tag isn't for ALICE-only use. This is my mistake, I should have created the tag in the original repository -- should I do so now or can we continue like this?

Cheers, Nazar

jackal1-66 commented 4 days ago

We can continue this way, just sync the tags on the original repo.

nburmaso commented 4 days ago

We can continue this way, just sync the tags on the original repo.

Hi @jackal1-66,

Done :) Could we please merge this PR if it is ok? Also, could you please add me to @alisw/pagmc?

Cheers, Nazar