search

alitrack / barcode-vba-macro-only

Barcode generator for LibreOffice and MSOffice as pure VBA macro
MIT License
21 stars 41 forks source link

barcody.bas won't encode numbers #4

Open makulais opened 6 years ago

makulais commented 6 years ago

If a number with no characters included in it is input as the string to be encoded, the QR gen file does not encode any value at all into the QR code. Tested with values of 0 - 65535, ... no value is encoded into the QR code. Tested with all ECL's, no value is encoded into the QR code. If a single character is included into the string, then the QR code will correctly implement the string, but if it is strictly numbers it will not.

JonasHeidelberg commented 6 years ago

Good catch! I might take some time over Christmas to look into this. If you need it quicker/want to get active yourself, I am sure it is in the same part of the code as the previous bugs I fixed (see https://github.com/jonasheidelberg/barcode-vba-macro-only, function qr_gen() in barcody.bas)

Am 18.12.2017 um 23:14 schrieb makulais notifications@github.com:

If a number with no characters included in it is input as the string to be encoded, the QR gen file does not encode any value at all into the QR code. Tested with values of 0 - 65535, ... no value is encoded into the QR code. Tested with all ECL's, no value is encoded into the QR code. If a single character is included into the string, then the QR code will correctly implement the string, but if it is strictly numbers it will not.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub, or mute the thread.

JonasHeidelberg commented 6 years ago

Hi, actually my fork had already fixed this bug for inputs from 10-65535 three weeks ago. I now also fixed it for single-digit numbers - you can find the updated code here: https://github.com/JonasHeidelberg/barcode-vba-macro-only/commits/quickfix-witwall-issue-4/barcody.bas Note you need to download the barcody.bas file - the XLSX is not updated yet. Hope this helps!

JonasHeidelberg commented 6 years ago

... I now also updated the XLSX and merged into my Master https://github.com/JonasHeidelberg/barcode-vba-macro-only Would love to hear if this solves your issue!

makulais commented 6 years ago

Worked great, I thought it might be an off-by-one, but it would have taken me forever to find it. Would love an explanation of how his code is working! Thank you. My company decided to go ahead and purchase a dll for use as we were concerned about bugs showing up during production, but I'll keep this as a back up in case we ever lose that driver due to upgrades, issues, ....

Thanks again, nice job.

Kennard

On Fri, Dec 22, 2017 at 4:16 PM, JonasHeidelberg notifications@github.com wrote:

... I now also updated the XLSX and merged into my Master https://github.com/JonasHeidelberg/barcode-vba-macro-only Would love to hear if this solves your issue!

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/witwall/barcode-vba-macro-only/issues/4#issuecomment-353683194, or mute the thread https://github.com/notifications/unsubscribe-auth/AhDk3RlhdfBrQDkcrp0EjS6aYfhiZp05ks5tDCpZgaJpZM4RGJhq .

JonasHeidelberg commented 6 years ago

Glad to hear you liked it! For commercial production code I completely agree with your company‘s decision! Until someone has made a somewhat extensive code review, this thing is a nice-to-have where you should always check that the output is what you expect...

Am 26.12.2017 um 16:59 schrieb makulais notifications@github.com:

Worked great, I thought it might be an off-by-one, but it would have taken me forever to find it. Would love an explanation of how his code is working! Thank you. My company decided to go ahead and purchase a dll for use as we were concerned about bugs showing up during production, but I'll keep this as a back up in case we ever lose that driver due to upgrades, issues, ....

Thanks again, nice job.

Kennard

On Fri, Dec 22, 2017 at 4:16 PM, JonasHeidelberg notifications@github.com wrote:

... I now also updated the XLSX and merged into my Master https://github.com/JonasHeidelberg/barcode-vba-macro-only Would love to hear if this solves your issue!

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/witwall/barcode-vba-macro-only/issues/4#issuecomment-353683194, or mute the thread https://github.com/notifications/unsubscribe-auth/AhDk3RlhdfBrQDkcrp0EjS6aYfhiZp05ks5tDCpZgaJpZM4RGJhq .

— You are receiving this because you commented. Reply to this email directly, view it on GitHub, or mute the thread.

kazu-kazu commented 5 years ago

QR gen If a comma is included in the number It cannot be recognized correctly. Please..

Example: In excel 555,0123456789,550,9999999999