search

alitrack / duckdb_fdw

DuckDB Foreign Data Wrapper for PostgreSQL
MIT License
272 stars 18 forks source link

Update for DuckDB 0.8.1 and enable DB name in table name #18

Closed Alex-Monahan closed 11 months ago

Alex-Monahan commented 11 months ago

Hello! Please let me know if there is anything else you'd like for me to do to make this easy to merge!

I made some minimal changes to the sqlite wrapper to support DuckDB 0.8.1 (just putting certain things within the DuckDB namespace).

I also changed how table names are handled. After the Attach syntax was added, DuckDB now has the concepts of database and schema. As a result, if a user passes in a fully qualified table name like my_db.my_schema.my_table, adding "main" or wrapping in double quotes would cause errors. This is also needed for MotherDuck to be able to be supported as a connection, as MotherDuck uses multiple databases.

alitrack commented 11 months ago

LGTM

Alex-Monahan commented 11 months ago

Thanks for merging! I was excited to finally get to give this a spin. I appreciate your work on it!