alixandru / q2a-open-login

Question2Answer Open Login plugin
62 stars 44 forks source link

Upgraded HybridAuth from "2.11.0" to "2.15.1", also fixed Google, Live and Twitter #86

Closed bertrandgorge closed 5 years ago

bertrandgorge commented 5 years ago

Tested and working:

Tested but not working:

Next patch I'll try to upgrade HybridAuth to version 3 (version 2 is not maintained anymore and given the pace of changes in each provider's implementation, it's better to be current)

bertrandgorge commented 5 years ago

Sure ! Sorry about that...! You should be able to merge it now.

alixandru commented 5 years ago

Reopening so I can merge the changes in

bertrandgorge commented 5 years ago

Hello Alixandru, I closed the merge request because for some reason it took a commit that did not belong to it, and I mixed everything up at that point :-)

I've just submitted a new patch that includes HybridAuth v3 - there's a few conflict because I didn't pull your merge before, but you can just keep my changes I believe.

You'll see that beyond the obvious files that have been changed from HybridAuth v2 to V3, there was not too much trouble upgrading, and from the tests that I could run, it works without any issue for at least Google, Facebook and Twitter.

If you have any questions we can talk of https://gitter.im or anything.