Upgraded to HybridAuth 3.00

bertrandgorge commented 5 years ago

Upgraded to HybridAuth 3.00 (https://github.com/hybridauth/hybridauth/releases/tag/v3.0.0)

In order to smooth the upgrade / merge process, the old Hybrid (v2) folder has been replaced with HybridAuth (v3)

Overall, the upgrade was not too complicated, I didn't have to change to many things. One main issue was the "associate providers" process, which didn't seem to work on the first place, and was quite problematic because it would require a callback URL with parameters, which many providers don't provide anymore.

Upgrade notes:

The callback URLs have changed: it should now be the root of the Q2A installation (both with and without index.php - depending on if you use neat urls or not). Beware of http/https, you might need to declare them.
Users of the Donut Theme should upgrade to the latest version, as this release has been specifically tested against it. Their is a new option to use q2a-open-login with Donut, mainly to display the login buttons with bootstrap.

This patch has been tested against Twitter, Facebook and Google with success.

bertrandgorge commented 5 years ago

See: https://github.com/amiyasahu/Donut/pull/110

alixandru commented 5 years ago

Hello! Thanks again for the pull request. Due to the fact that I merged the other commits I need to manually fix the conflicts. I hope to be able to do that this weekend. I will get back to you soon.

bertrandgorge commented 5 years ago

Thanks - do not hesitate to come back to me, I'll try to be reactive if there's anything...!

Le sam. 31 août 2019 à 10:52, alixandru notifications@github.com a écrit :

Hello! Thanks again for the pull request. Due to the fact that I merged the other commits I need to manually fix the conflicts. I hope to be able to do that this weekend. I will get back to you soon.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/alixandru/q2a-open-login/pull/87?email_source=notifications&email_token=ADAAVDPXWGUTGMG7WTCO43LQHIWK7A5CNFSM4IQFEXLKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD5TISTQ#issuecomment-526813518, or mute the thread https://github.com/notifications/unsubscribe-auth/ADAAVDIMXMMLJQLRTFCJSJDQHIWK7ANCNFSM4IQFEXLA .

bertrandgorge commented 4 years ago

Hello @alixandru, have you add time to review the changes ? Tell me if I can be of any help!

akien-mga commented 3 years ago

Hi there. We recently upgraded our q2a instance to 1.8.5 at https://godotengine.org/qa/ and it seems that Open Login broke. We tried latest master which includes parts of this PR but it seems to have been left in a non functional state, as having any provider enabled gives a redirect loop (we used to use Facebook and GitHub providers, and we mostly care about the latter).

@bertrandgorge Does the current state of your master branch (the base for this PR) work for you?

Since @alixandru merged a partial state manually, the best would likely be to create a new dedicated branch for a PR that would be rebased on alixandru/master.

We'd really love to have a functioning q2a-open-login matching latest q2a 1.8.5. Thanks!

bertrandgorge commented 3 years ago

Hello @akien-mga ! I believe that this repo is not up to date with my last commits, probably because of me - my first attempts at providing a clean PR were not that great. You can check https://github.com/neayi/q2a-open-login as it functional for me and a bit ahead. Do not hesitate to contact me directly if you want to discuss it directly

coelhorusso commented 2 years ago

O plugin não está funcionando corretamente no Facebook e Google? Tem alguém usando com sucesso neles atualmente?

alixandru / q2a-open-login

Upgraded to HybridAuth 3.00 #87