search

alixinne / hyperion.rs

Rust implementation of the Hyperion Ambient Lighting software
MIT License
10 stars 1 forks source link

Feaure-flagging LED effects (pyo3) #2

Closed tuxuser closed 2 years ago

tuxuser commented 2 years ago

Hey!

How do you think about feature-flagging the python-dependant component "effects"? It certainly helps the build process on embedded platforms ;)

Here is an example branch, implementing the feature effects: https://github.com/tuxuser/hyperion.rs/tree/task/feature_flag/py3 (the branch additionally adds another build target)

Do you consider it useful? And if so, how shall we proceed?

cheers

alixinne commented 2 years ago

Hello!

I was thinking about adding such a feature flag (third-party dependencies are indeed a pain on embedded platforms). As you've noticed the effect feature does creep up everywhere so feature-gating it does get ugly quite fast.

Thanks for doing the initial work, I'll review it in more detail in the coming days and let you know how we could proceed!