search

aliyun / SimAI

Apache License 2.0
88 stars 13 forks source link

Fix heap buffer overflow when running simulation #14

Open HeRaNO opened 2 weeks ago

HeRaNO commented 2 weeks ago

Close #6

Huoyuan100861 commented 1 week ago

This change might affect the correctness of the generated tree node results, requiring validation.

HeRaNO commented 1 week ago

I'm not sure about this change. But the overflow does exist. Formally, the operation % nodes.size() should be placed inside the index.

I will take a deeper look into it. Feel free to suppress this PR if you have a fix.