search

aliyun / SimAI

Apache License 2.0
82 stars 12 forks source link

Infinite loop when the -c parameter of the SimAI_simulator command is empty #17

Open dageita opened 2 days ago

dageita commented 2 days ago

I noticed that the parameter -c is required in the new version v1.0, and tutorial has not been updated yet. Using SimAI_simulator without -c will result in an infinite loop, I think this is due to this code segment:

bool ReadConf(string network_topo,string network_conf) {

    std::ifstream conf;
    conf.open(network_conf);
    topology_file = network_topo;
    while (!conf.eof()) {
      std::string key;
      conf >> key;

Should exception handler added?

Huoyuan100861 commented 2 days ago

Yes, you need to add the -c flag to specify the configuration file, which is astra-sim-alibabacloud/inputs/config/SimAI.conf. The hanging issue is due to slight changes in the format of workload parsing in the new SimAI-Analytical (mainly to support VPP). You can try example/workload_analytical.txt. I will update this part accordingly later.