search

aliyun / alibaba-cloud-sdk-go

Alibaba Cloud SDK for Go
Apache License 2.0
1.16k stars 273 forks source link

Using a Local Copy of http.DefaultClient for Isolated Configuration In instance_credentials.go #613

Closed ChenHaoHu closed 5 months ago

ChenHaoHu commented 8 months ago

Declaring httpClient as a replica of http.DefaultClient instead of directly using http.DefaultClient ensures that global settings of http.DefaultClient remain unaffected, preventing any unintended consequences on other business logic and dependencies.

CLAassistant commented 8 months ago

CLA assistant check
All committers have signed the CLA.

ChenHaoHu commented 8 months ago

@sdk-team hello

codecov-commenter commented 7 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (779f3d3) 93.52% compared to head (4e0cc2e) 93.52%. Report is 71 commits behind head on master.

:exclamation: Current head 4e0cc2e differs from pull request most recent head 53116a1. Consider uploading reports for the commit 53116a1 to get more accurate results

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #613 +/- ## ======================================= Coverage 93.52% 93.52% ======================================= Files 48 48 Lines 2518 2518 ======================================= Hits 2355 2355 Misses 106 106 Partials 57 57 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

JacksonTian commented 5 months ago

fixed in #618