search

aliyun / aliyun-odps-java-sdk

ODPS SDK for Java Developers
Other
89 stars 50 forks source link

Update TextExtractor.java #19

Closed yuanice closed 5 years ago

yuanice commented 5 years ago

alter ""," split question

CLAassistant commented 5 years ago

CLA assistant check
All committers have signed the CLA.

kilowu commented 5 years ago

Hi, @yuanice Could you provide an full example addressing the issue

yuanice commented 5 years ago

Hi, @yuanice Could you provide an full example addressing the issue quoteStarted完全没有意义在这

图片
cornmonster commented 5 years ago

Hi, @yuanice Could you provide an full example addressing the issue quoteStarted完全没有意义在这

图片

Hi,

I have reviewed your commit. What you said does make sense, but line 272 "quoteStarted = false;" should be removed, right?

Thanks, Jon

yuanice commented 5 years ago

I have reviewed your commit. What you said does make sense, but line 272 "quoteStarted = false;" should be removed, right?

no,line 269 "!quoteStarted " should be removed, for example csv context is : "a","b" ,They can't split properly.If you don't want to romve "!quoteStarted" ,only romve "!" It's ok

lyman commented 5 years ago

Seems travis changed behavior due to security risk which caused CI failure. Merge first anyway and fix CI ASAP.

kilowu commented 5 years ago

I have reviewed your commit. What you said does make sense, but line 272 "quoteStarted = false;" should be removed, right?

no,line 269 "!quoteStarted " should be removed, for example csv context is : "a","b" ,They can't split properly.If you don't want to romve "!quoteStarted" ,only romve "!" It's ok

It's indeed a bug. Thank you @yuanice

By the way, the TextExtractor is only an example for demo purpose. Please use built-in com.aliyun.odps.CsvStorageHandler if your files are CSV based format.

yuanice commented 5 years ago

I have reviewed your commit. What you said does make sense, but line 272 "quoteStarted = false;" should be removed, right?

no,line 269 "!quoteStarted " should be removed, for example csv context is : "a","b" ,They can't split properly.If you don't want to romve "!quoteStarted" ,only romve "!" It's ok

It's indeed a bug. Thank you @yuanice

By the way, the TextExtractor is only an example for demo purpose. Please use built-in com.aliyun.odps.CsvStorageHandler if your files are CSV based format.

CsvStorageHandler There are problems，do not work correctly when files are CSV

kilowu commented 5 years ago

CsvStorageHandler There are problems，do not work correctly when files are CSV

@yuanice Could you open an issue and describe the problems in CsvStorageHandler? Thank you in advance.

yuanice commented 5 years ago

CsvStorageHandler There are problems，do not work correctly when files are CSV

@yuanice Could you open an issue and describe the problems in CsvStorageHandler? Thank you in advance. for example csv context is : "a","b b1" It's going to split into two rows.