aliyun / aliyun-openapi-net-sdk

Alibaba Cloud SDK for .NET
https://www.nuget.org/profiles/aliyun-openapi-sdk
Other
541 stars 625 forks source link

Add https certificate #184

Closed doublnt closed 5 years ago

doublnt commented 5 years ago
You need to complete
codecov-io commented 5 years ago

Codecov Report

Merging #184 into master will decrease coverage by 0.12%. The diff coverage is 84.84%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #184      +/-   ##
==========================================
- Coverage   92.66%   92.54%   -0.13%     
==========================================
  Files          62       62              
  Lines        2960     2992      +32     
  Branches      280      282       +2     
==========================================
+ Hits         2743     2769      +26     
- Misses        173      178       +5     
- Partials       44       45       +1
Flag Coverage Δ
#unittest 92.54% <84.84%> (-0.13%) :arrow_down:
Impacted Files Coverage Δ
aliyun-net-sdk-core/Http/HttpResponse.cs 86.25% <100%> (+0.89%) :arrow_up:
aliyun-net-sdk-core/Http/HttpRequest.cs 100% <100%> (ø) :arrow_up:
aliyun-net-sdk-core/DefaultAcsClient.cs 84.03% <64.28%> (-1.17%) :arrow_down:
...dk-core/Auth/InstanceProfileCredentialsProvider.cs 97.22% <0%> (-2.78%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 471a19f...8d3ff82. Read the comment docs.

AxiosLeo commented 5 years ago

codecov减了0.13,有点小多哦

JacksonTian commented 5 years ago

只要实现 setHTTPInsecure 就可以了。传证书暂时不要实现。等实际需求出现后再实现。

JacksonTian commented 5 years ago

分割到两个 PR 中去吧

doublnt commented 5 years ago

分割到两个 PR 中去吧

好的,我分两个PR提交