doublnt commented 5 years ago

本PR主要是 Credential 中的文件结构，目录存放以及路径地址的。对之前的Credential 的实现进行的第一步重构。大体的三种 Credential，第一种是 BasicCredential 第二种是 StsCredential 第三种是 BearertokenCredential，分为多个 Provider 来提供这三个类别的 Credential。

codecov-io commented 5 years ago

Codecov Report

Merging #225 into master will decrease coverage by 0.79%. The diff coverage is 63.41%.

@@            Coverage Diff            @@
##           master     #225     +/-   ##
=========================================
- Coverage   95.63%   94.84%   -0.8%     
=========================================
  Files          65       62      -3     
  Lines        3115     3101     -14     
  Branches      291      291             
=========================================
- Hits         2979     2941     -38     
- Misses         84      106     +22     
- Partials       52       54      +2

Flag	Coverage Δ
#unittest	`94.84% <63.41%> (-0.8%)`	:arrow_down:

Impacted Files	Coverage Δ
aliyun-net-sdk-core/Auth/Signer/HmacSHA1Signer.cs	`100% <ø> (ø)`
...un-net-sdk-core/Auth/Signer/SHA256withRSASigner.cs	`100% <ø> (ø)`
...iyun-net-sdk-core/Auth/Signer/BearerTokenSigner.cs	`100% <ø> (ø)`
...core/Auth/Credential/InstanceProfileCredentials.cs	`100% <ø> (ø)`
...dk-core/Auth/Credential/BasicSessionCredentials.cs	`100% <ø> (ø)`
...et-sdk-core/Auth/Provider/StsCredentialProvider.cs	`0% <0%> (ø)`
...-core/Auth/Provider/AccessKeyCredentialProvider.cs	`0% <0%> (ø)`
...dk-core/Auth/Provider/StaticCredentialsProvider.cs	`100% <100%> (ø)`
...h/Provider/ECSMetadataServiceCredentialsFetcher.cs	`93.25% <100%> (ø)`
...-net-sdk-core/Auth/Credential/LegacyCredentials.cs	`100% <100%> (ø)`
... and 10 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 038a336...9d7d8c0. Read the comment docs.

AxiosLeo commented 5 years ago

codecov下降的有点多，后续可以补一下

aliyun / aliyun-openapi-net-sdk

Credential structure refactor #225

Codecov Report