aliyun / aliyun-openapi-net-sdk

Alibaba Cloud SDK for .NET
https://www.nuget.org/profiles/aliyun-openapi-sdk
Other
541 stars 625 forks source link

DefaultAcsClient's DoAction<T> overload methods have BUG #29

Closed VAllens closed 6 years ago

VAllens commented 6 years ago

Error Code

FormatType? requestFormatType = request.AcceptFormat;
if (null != requestFormatType)
{
    format = requestFormatType;
}

Right Code

if (null == format)
{
    format = request.AcceptFormat;
}

I see that this method has Nullable type parameter format. I thought you were going to judge if the parameter format was empty, otherwise the code if (null != requestFormatType) would be meaningless. Because it's always true.

conan425 commented 6 years ago

We will consider your suggestion,Thank you very much!