Closed jxltom closed 4 years ago
merged
Why this PR is merged without my author information. It is quite uncommon in open source.
@jxltom, because the maintainer merged a combined PR (https://github.com/aliyun/django-oss-storage/pull/24), which makes you the indirect author, and not shown on https://github.com/aliyun/django-oss-storage/graphs/contributors.
Anyway, the project doesn't have a contributor file.
Obviously, the merged PR could of course cherrypick my commits which includes my author information. It is much better way for open source projects.
Step to reproduce:
file_example2
already exists in OSS,exists()
function will return True for filefile_example
even though it is not. Thencollectstatic
will try to get meta data of this file and then error will be raised since file does not actually exist.Reason:
os.path.normpath
will remove/
which is at the end of path. For example,/path/path/
will be normalized to/path/path
. So theexits()
method which checks existence of a folder byself.bucket.list_objects(prefix='/path/path/', delimiter='', marker='', max_keys=1)
is actually checking byself.bucket.list_objects(prefix='/path/path', delimiter='', marker='', max_keys=1)
without/
at the end ofprefix
How to fix:
/
.