search

aliyun / django-oss-storage

Django storage backends for AliCloud OSS.
MIT License
145 stars 67 forks source link

OssStorage provides __init__ arguments #4

Closed TonyPythoneer closed 6 years ago

TonyPythoneer commented 6 years ago

Hello, @baiyubin @abo321

I hope OssStorage can populate arguments when initializing instance. It's more flexible for developer using. Please review this. Thanks!

TonyPythoneer commented 6 years ago

請問負責這個 repo 的聯絡窗口是誰？能不能出來回應一下？

cc @baiyubin @abo321

TonyPythoneer commented 6 years ago

已經過了一個禮拜了，請問為什麼沒有人回應？

cc @baiyubin @abo321 @oldratlee

abo969 commented 6 years ago

@TonyPythoneer ,

Really appreciate your feedback on this. Could you please describe your use case in detail for developer? Initially by design we would like to config AK, bucket and endpoint firstly in env variables or in setting.py.

Again, thank you!

TonyPythoneer commented 6 years ago

Hi @abo321,

Because I expect each bucket can store specified file type, I need to initialize storage by different oss key and mange that, for example:

  1. Pictures store in picture bucket
  2. Audios store in audio bucket
  3. Vedios store in vedio bucket

If keep original, the files will store in the same bucket. It's not something I wanted.

I requires offering more flexible initializing methods to match my demand.

Thansks for your response.

abo969 commented 6 years ago

It sounds reasonable. Please provide test code as you write function code. And see my comments inline.

CLAassistant commented 6 years ago

CLA assistant check
All committers have signed the CLA.

TonyPythoneer commented 6 years ago

Hello @abo321 , I had added testcases, please review it.

By the way, when do you add @CLAassistant ?

TonyPythoneer commented 6 years ago

@abo321 What do you mean?

abo969 commented 6 years ago

I just reviewed your code and think it can be merged to the main stream. Then the owner will merge that. You don't need to know that since this is just the process here.

TonyPythoneer commented 6 years ago

@abo321 OK, I hope it can merge into master branch as soon as possible.