aliz-ai / gcpimp

Apache License 2.0
0 stars 0 forks source link

Cost calculation is wrong #17

Open gsipos opened 6 years ago

gsipos commented 6 years ago

Cost metrics that are above 1000 can be displayed in various ways, like 1 234,567 1.234,567 1,234.567 And it is not currently handled well.

fpeter8 commented 5 years ago

Proposed solution: Collect all numbers as string, and try to figure out the format from all of them before the actual parsing takes place (so if there is a single number where we know the format, we can apply it to the others)

If we don't know the format we should not display a cost estimate as it could be way off.

Possible additional rules (needs checking):