aljawaid / PluginManager

Replace the Installed Plugins section with a whole new interface. Plugin Manager provides both users and developers with an improved layout displaying a new section for troubleshooting plugins with a new plugin structure breakdown for each plugin. Install plugins directly or explore new upcoming or untested features from manual plugins.
MIT License
17 stars 3 forks source link

The stylesheet leaks into all pages #27

Closed Chaosmeister closed 1 year ago

Chaosmeister commented 1 year ago

After installing the PluginManager, all pages get styled with the plugin-manager.css

aljawaid commented 1 year ago

Please send screenshots... which styles? If you have KanboardCSS installed, it is normal. Some of the text styles could possibly crossover to other pages but I would need to know which/where the text is in order to target it.

aljawaid commented 1 year ago

After installing the PluginManager, all pages get styled with the plugin-manager.css

the whole of the plugins/extensions section gets restyled.

aljawaid commented 1 year ago

Looking at the stylesheet a bit closer, you may be possibly affected by:

None of the above should cause a negative impact to your instance. Either way, I would need more specific information.

Chaosmeister commented 1 year ago

heyo, I don't use KanboardCSS

examples:

in ?controller=DashboardController image

in ?controller=BoardViewController image

aljawaid commented 1 year ago

Cool, I will work on those shortly

aljawaid commented 1 year ago

Done, I will release a new version once the plugin actually gets listed. #26

Chaosmeister commented 1 year ago

the table still gets borders from here

image

on the board view, tasks also still get underlined by this image

maybe it would be easier to just include the pluginmanager css on the pluginmanager site?

aljawaid commented 1 year ago

maybe it would be easier to just include the pluginmanager css on the pluginmanager site? what do you mean?

Chaosmeister commented 1 year ago

you could for example only hook the css or the whole plugin if controller=PluginController

aljawaid commented 1 year ago

you could for example only hook the css or the whole plugin if controller=PluginController

I'm not sure I understand what you mean... any sample code to share?

Chaosmeister commented 1 year ago

something like this:

public function initialize()
{
    // abort initialization on non pluginmanager sites
    if ("PluginController" != $this->request->getStringParam("controller"))
    {
        return;
    }