search

alkacon / alkacon-oamp

OAMP - the Alkacon OpenCms additional module packages.
http://www.alkacon.com
GNU General Public License v3.0
27 stars 38 forks source link

Broken build (branch_9_0_x and branch_9_5_x) #31

Open gallardo opened 10 years ago

gallardo commented 10 years ago

If I build against opencms_version from ms_9_4_7 or branch_9_5_x (neither opencms-core tag build_9_0_1 nor branch branch_9_0_x do build), I get the error CmsConfigurableCollector is not abstract ...:

Against 9.4.7:

[...]/alkacon-oamp/com.alkacon.opencms.v8.comments/src/com/alkacon/opencms/v8/comments/CmsCommentsAccess.java:1019: error: incompatible types: Object cannot be converted to Entry<String,String[]>
            for (Map.Entry<String, String[]> entry : CmsRequestUtil.createParameterMap(req.getParameterMap()).entrySet()) {
                                                                                                                      ^
Note: [...]/alkacon-oamp/com.alkacon.opencms.v8.comments/src/com/alkacon/opencms/v8/comments/CmsCommentsAccess.java uses unchecked or unsafe operations.
Note: Recompile with -Xlint:unchecked for details.
1 error

Against 9.5.x:

[...]/alkacon-oamp/com.alkacon.opencms.commons/src/com/alkacon/opencms/commons/CmsConfigurableCollector.java:70: error: CmsConfigurableCollector is not abstract and does not override abstract method getResults(CmsObject,String,String,int) in I_CmsResourceCollector
public class CmsConfigurableCollector extends A_CmsResourceCollector {
       ^
1 error
10 warnings
gallardo commented 10 years ago

The commit modifying I_CmsResourceCollector (and thus breaking alkacon-oamp) is the commit https://github.com/alkacon/opencms-core/commit/d3344bcf86c02052b0343c41de87b94baf25b56c#diff-17 (2014-08-04), lives in the branch https://github.com/alkacon/opencms-core/tree/branch_9_5_x, and has not been tagged yet.