alkaline-ml / pmdarima

A statistical library designed to fill the void in Python's time series analysis capabilities, including the equivalent of R's auto.arima function.
https://www.alkaline-ml.com/pmdarima
MIT License
1.57k stars 231 forks source link

Absolute paths in source distribution prevent Windows installation #448

Closed tomasvanpottelbergh closed 3 years ago

tomasvanpottelbergh commented 3 years ago

Describe the bug

The source distribution published on PyPI contains the following absolute paths in pmarima.egg-info/SOURCES.txt:

/Users/runner/hostedtoolcache/Python/3.6.13/x64/lib/python3.6/site-packages/numpy/core/include/numpy/arrayobject.h
/Users/runner/hostedtoolcache/Python/3.6.13/x64/lib/python3.6/site-packages/numpy/core/include/numpy/ufuncobject.h

This results in the following error when installing from the source distribution on Windows via pip install .:

    ValueError: path '/Users/runner/hostedtoolcache/Python/3.6.13/x64/lib/python3.6/site-packages/numpy/core/include/numpy/arrayobject.h' cannot be absolute
    Running setup.py install for pmdarima ... error

To Reproduce
Steps to reproduce the behavior:

Workarounds

Versions

System:
    python: 3.9.6 (default, Aug 18 2021, 15:44:49) [MSC v.1916 64 bit (AMD64)]
executable: C:\Users\User\miniconda3\envs\pmdarima-build\python.exe
   machine: Windows-10-10.0.19043-SP0

Python dependencies:
        pip: 21.2.4
 setuptools: 52.0.0.post20210125
    sklearn: 0.24.2
statsmodels: 0.12.2
      numpy: 1.19.5
      scipy: 1.7.1
     Cython: 0.29.24
     pandas: 1.3.2
     joblib: 1.0.1
   pmdarima: 1.8.2

Expected behavior An installable source distribution.

Additional context

I struggled with this when trying to add Windows support to the conda-forge package. I cannot reproduce the generation of a source distribution with such paths.

aaronreidsmith commented 3 years ago

Interesting! I am able to reproduce this by building the wheel before the source distribution (which is what we do in our build pipeline). Working on #450 to resolve that. Thanks for the report!

aaronreidsmith commented 2 years ago

This should be fixed in version 1.8.3 which went out today