Closed anne-decusatis closed 2 years ago
Looks like the failing tests are failing on make clean
. I'm not familiar with the setup of this repo but it seems likely to me that it's not related to this change.
The CI/CD is broken because of a new setuptools version that was released recently. I have a fix up in #491. We'll merge your fix in once we get that one merged in!
@anne-decusatis can you update your branch to have the latest master changes? GitHub won't let me merge this without all the status checks 😬
Description
Please include a summary of the change and which issue is fixed:
When reading the docs I noticed that n_fits (which is used to determine the number of test iterations used to fit in random search cases) is sometimes referred to as n_iter. It looks like n_fits is the variable name that's actually in use. I looked for usages of n_iter and changed the ones which referred to n_fits. This is a very minor change which affects a few comments, one reference in documentation, and the text of a single error that's thrown if n_fits is negative. Please feel free to edit or reject.
Fixes # n/a This is such a minor change (at first I thought it was doc-only) that I didn't file an issue first. Please let me know if I need to!
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
I haven't run tests locally because this doesn't really change any functionality - I expect the CI to succeed, if it doesn't I can debug locally.
Checklist: