alkaline-ml / pmdarima

A statistical library designed to fill the void in Python's time series analysis capabilities, including the equivalent of R's auto.arima function.
https://www.alkaline-ml.com/pmdarima
MIT License
1.58k stars 232 forks source link

[MRG+1] - Refactor seasonality module #571

Closed chrimaho closed 7 months ago

chrimaho commented 7 months ago

Description

Primary purpose here is to refactor the CHTest() class to add a new method _calc_ch_crit_val(). This brings it in-line with the OCSBTest() class, and will enable the user to extract the specific critical value used for the test.

The functionality does not change, all other processes remain the same.

While adding this change, I ran the black formatting on the seasonality module, which caused quite a few changes.

Type of change

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

Checklist:

chrimaho commented 7 months ago

Hi @tgsmith61591, updates are now made. Please check.