alkanet88 / upgraded-pancake

0 stars 0 forks source link

Sweep: write py code for this story that i will write in the comments #4

Open alkanet88 opened 1 year ago

alkanet88 commented 1 year ago

Terpsichore, the muse of dance, tells you about this dance sequence that is to be animated in python: o /|\ /\

it goes left, then right, right on the screen, moving 3 spaces each time, then repeats for 5 times

Checklist - [X] `animation.py` ✅ Commit [`f1b023e`](https://github.com/alkanet88/upgraded-pancake/commit/f1b023ec356b89c6d610d1a6d35a620db8982096)
upmortem-sweep[bot] commented 1 year ago

Here's the PR! https://github.com/alkanet88/upgraded-pancake/pull/5.

💎 Sweep Pro: I'm creating this ticket using GPT-4. You have unlimited GPT-4 tickets.

Actions (click)


Step 1: 🔎 Searching

I found the following snippets in your repository. I will now analyze these snippets and come up with a plan.

Some code snippets I looked at (click to expand). If some file is missing from here, you can mention the path in the ticket description. https://github.com/alkanet88/upgraded-pancake/blob/be61394a1c7db4cd5d0d1347616861d157d7c560/README.md#L1-L22 https://github.com/alkanet88/upgraded-pancake/blob/be61394a1c7db4cd5d0d1347616861d157d7c560/not-empty#L1-L7

Step 2: ⌨️ Coding


Step 3: 🔁 Code Review

Here are my self-reviews of my changes at sweep/add-python-script.

Here is the 1st review

Hello, great start on the animation script! There are a couple of changes needed to ensure the stick figure moves both left and right as required. - In `animation.py` on lines 4-9, the `print_figure` function needs to be updated to handle the 'left' direction. Currently, the stick figure only moves to the right. You can fix this by subtracting 3 from the position when the direction is 'left'. - In `animation.py` on lines 11-19, the position is always increased by 3 in the main loop, regardless of the direction of movement. This means the stick figure only moves to the right. To fix this, you can add a condition to check the direction of movement and update the position accordingly. Keep up the good work!

I finished incorporating these changes.


🎉 Latest improvements to Sweep:


💡 To recreate the pull request edit the issue title or description. To tweak the pull request, leave a comment on the pull request. Join Our Discord