alkem-io / client-web

Default web frontend, enabling browsing the Alkemio platform - so the hosted Challenges and communities collaborating around those Challenges.
https://alkem.io
European Union Public License 1.2
15 stars 6 forks source link

Threaded interactions UI adjustments #6520

Closed techsmyth closed 1 month ago

techsmyth commented 1 month ago

Description

With the new threaded interactions, it is impossible to interact with multiple VCs in one thread (see sketch below for terminology, each thread can hold 1 vc-interaction). As a user, I want to understand this when I'm interacting with VCs.

image.png

Acceptance criteria

Additional Context

image.png

Add text below the Virtual Contributor tag, tooltip when user hovers over the card

Areas that will be affected

To be added during the refinement

techsmyth commented 1 month ago

@SimoneZaza for clarity: one VC in the thread, at the start but also further down?

SimoneZaza commented 1 month ago

@techsmyth I would actually prefer not to restrict at all, but as I understood it this was a technical requirement. Just to be sure, below a sketch of how I understand the terms post/comment/thread. If we restrict I would either go for '1 VC in the thread, everywhere in the thread' or '1 VC per message (comment or inside the thread).' The latter would allow for multiple VCs in 1 thread, which would be very interesting..

image.png
valeksiev commented 1 month ago

The behaviour in the AC can not be achieved as putting a tag suggestion in disabled state is impossible with the library we use for mentioning. I implemented an alternative flow, achieving the same limitations.

  1. When a root comment is being composed the completion list looks as-is:

    image.png
  2. When replying in a thread with VC already involved, a message above the list is displayed with a help tooltip with further explanation. All VCs are filtered out:

    image.png
  3. When replying to a thread without a VC involved the suggestion list is as-is:

    image.png
valeksiev commented 1 month ago

There is a logic which disallows tagging the same person twice, which was not working, and I fixed it as I was already touching the components.

Unfortunately, now it's misbehaving - should we discuss and try to tidy it up as part of this or should I break it again and track it separately? cc @SimoneZaza @techsmyth

valeksiev commented 1 month ago

After a discussion with @techsmyth it was decided to disable VCs for event comments.