Closed techsmyth closed 1 month ago
@SimoneZaza for clarity: one VC in the thread, at the start but also further down?
@techsmyth I would actually prefer not to restrict at all, but as I understood it this was a technical requirement. Just to be sure, below a sketch of how I understand the terms post/comment/thread. If we restrict I would either go for '1 VC in the thread, everywhere in the thread' or '1 VC per message (comment or inside the thread).' The latter would allow for multiple VCs in 1 thread, which would be very interesting..
The behaviour in the AC can not be achieved as putting a tag suggestion in disabled state is impossible with the library we use for mentioning. I implemented an alternative flow, achieving the same limitations.
When a root comment is being composed the completion list looks as-is:
When replying in a thread with VC already involved, a message above the list is displayed with a help tooltip with further explanation. All VCs are filtered out:
When replying to a thread without a VC involved the suggestion list is as-is:
There is a logic which disallows tagging the same person twice, which was not working, and I fixed it as I was already touching the components.
Unfortunately, now it's misbehaving - should we discuss and try to tidy it up as part of this or should I break it again and track it separately? cc @SimoneZaza @techsmyth
After a discussion with @techsmyth it was decided to disable VCs for event comments.
Description
With the new threaded interactions, it is impossible to interact with multiple VCs in one thread (see sketch below for terminology, each thread can hold 1 vc-interaction). As a user, I want to understand this when I'm interacting with VCs.
Acceptance criteria
Additional Context
Add text below the Virtual Contributor tag, tooltip when user hovers over the card
Areas that will be affected
To be added during the refinement