Updated Demo.Simple app - Resolves Demo.Simple #9

valentinyanakiev commented 4 years ago

Describe the background of your pull request

What does your pull request do? Does it solve a bug (which one?), add a feature?

Additional context

Add any other context

Governance

[x] Documentation is added
[ ] Test cases are added or updated
[x] I've read the contributing document https://github.com/cherrytwist/.github/blob/master/CONTRIBUTING.md
[x] I've read and understand the Code of Conduct https://github.com/cherrytwist/.github/blob/master/CODE_OF_CONDUCT.md
[x] I understand that any contributions or suggestions I made may make it into the actual code. I've read the License https://github.com/cherrytwist/Coordination/blob/master/LICENSE and the contributor license agreement: tba

welcome[bot] commented 4 years ago

Thanks for opening this pull request! Please check out our contributing guidelines.

valentinyanakiev commented 4 years ago

Great update, just need to fix the diagram. The web client container runs NGINX internally (and not Traefik/Kubernetes) and exposes port 80 (so no TLS).

I kind of mixed the purpose of the diagram - now showing "external" k8s access and internal, docker-compose access (what was initially intended) - so users / contributors understand the paradigm. Also did a little cleanup.

welcome[bot] commented 4 years ago

Congrats on merging your first pull request! We at CherryTwist thank you for your contribution!

alkem-io / demo