search

alkem-io / server

Core server in the Alkemio platform, offering a GraphQL api for interacting with the logical domain model.
http://alkem.io
European Union Public License 1.2
24 stars 4 forks source link

BUG: server crash on error in application #3894

Open Comoque1 opened 4 months ago

Comoque1 commented 4 months ago

Describe the bug A clear and concise description of what the bug is.

To Reproduce Steps to reproduce the behavior:

  1. Go to localhost:3000
  2. Create a public space with public challenge
  3. Using a non member user create application directly to the challenge
  4. Using the admin of the challenge approve the application - the server crash image.png

Expected behavior User cannot apply on subspace, without being a member on parent.

techsmyth commented 4 months ago

@Comoque1 just tried this flow out. The client gave the appropriate message to first join the parent space - so that seems to be ok. I also tried going to the apply directly + then got the following page:

image.png

So something goes wrong in the client - low priority as users should not be able to get to this page. So please retest and if flow works for users then close...

Comoque1 commented 3 months ago

@techsmyth , you are right, at the time of the issue has been raised, the flows on the client were broken, so now using the client, cannot be reproduce (at least not a direct flow).

Still, if for some reason, a user has or creates an application on a subspace, without being a space member , and someone approve it, the server crash (tested on dev env.).

image.png
techsmyth commented 3 months ago

@Comoque1 this is an exception cascade issue, will need Svetlo to have look at this re why the error triggers a server crash...

Comoque1 commented 3 months ago

Tested locally with latest changes and the server still crash. @hero101 , could you please have a look at the issue, when you have the time?