search

alkem-io / server

Core server in the Alkemio platform, offering a GraphQL api for interacting with the logical domain model.
http://alkem.io
European Union Public License 1.2
26 stars 4 forks source link

BUG: On a VC / settings / settings page when ` Include in public selection lists` flag is on, the VC is considering it, no matter the Visibility state #4169

Closed Comoque1 closed 4 months ago

Comoque1 commented 4 months ago

Describe the bug A clear and concise description of what the bug is.

To Reproduce Steps to reproduce the behavior:

  1. Go to http://localhost:3000/vc/music-public-not-in-libra/settings/settings or a vc settings page

  2. Make the VC public

  3. Set the flag: Include in public selection lists: true

  4. Make the VC hidden or private

    image.png

  5. Run the query: 

    query{
platform{
library{
  virtualContributors{
    searchVisibility
    listedInStore
    profile{
      displayName
    }
  }
}
}
}

  6. The VC is displayed in the Library list:

    image.png

Expected behavior When the Visibility is different from Public, listedInStore must always be false

bobbykolev commented 4 months ago

I'm applying a client-side filtering for the Library VC. The client will expose only Public VCs from the library.

The switch for listing in the library (n VC settings) will remain unchanged for now. We can further refine it's UX.

Comoque1 commented 4 months ago

Reopening the bug, as this should be handled on server level and transferring it to server repository.