fix: base off existing branch only if it exists and has an open pull request

all-contributors / app

🤖 A GitHub App to automate acknowledging contributors to your open source projects

https://allcontributors.org

MIT License

576 stars 150 forks source link

fix: base off existing branch only if it exists and has an open pull request #338

Closed hertzg closed 2 years ago

hertzg commented 3 years ago

Fixes #336

⚠️ WIP ⚠️

TODO:

[ ] Save nock response snapshots for new pull request checks in happy paths

vercel[bot] commented 3 years ago

@hertzg is attempting to deploy a commit to the All Contributors Team on Vercel.

A member of the Team first needs to authorize it.

hertzg commented 2 years ago

Hey @tenshiAMD, unfortunately I don't have time to work on this pr now, but feel free to finish it if it's a priority right now or let me know and I can close this.

tenshiAMD commented 2 years ago

@gr2m I think this is the current behavior now. See any differences? Please check. Thanks.

tenshiAMD commented 2 years ago

@hertzg Hi. Looks like the other tests got broken. Any ideas? What else are we missing here?

gr2m commented 2 years ago

I'll try to have look this week but can't promise

hertzg commented 2 years ago

@tenshiAMD Are you sure they just broke?

There’s a TODO on top of the PR

TODO:

[ ] Save nock response snapshots for new pull request checks in happy paths

tenshiAMD commented 2 years ago

@tenshiAMD Are you sure they just broke?

There’s a TODO on top of the PR

TODO:

[ ] Save nock response snapshots for new pull request checks in happy paths

@hertzg yes I already update the snapshots, you can review the recent checks in this PR

tenshiAMD commented 2 years ago

Closing for now. Recreated to a new PR https://github.com/all-contributors/app/pull/415.