search

all-contributors / app

🤖 A GitHub App to automate acknowledging contributors to your open source projects
https://allcontributors.org
MIT License
576 stars 150 forks source link

New line missing when adding "Contributions of any kind welcome!" paragraph to the end of README #340

Closed gr2m closed 2 years ago

gr2m commented 3 years ago

Describe the bug

My prettier linter complained that the README.md no longer complies after I merged the initial pull request of the All Contributors app. The app added the "Contributors" section. That change trimmed the new line from the end of the README:

To Reproduce

Steps to reproduce the behavior:

  1. In a repository that does not have the app installed yet, and does not yet have the contributors section in the README, install the app
  2. Ask the app to add someone as contributor
  3. The resulting PR removes the new line from the README

Expected behavior

The README.md file changes should adhere to the prettier formatting rules

Additional context

Failing lint build: https://github.com/probot/create-probot-app/runs/1690285771?check_suite_focus=true

tenshiAMD commented 2 years ago

@gr2m this issue does not occur anymore I've just tested this here https://github.com/tenshiAMD/sandbox-ac/pull/2/files. Closing this for now.