search

all-contributors / app

🤖 A GitHub App to automate acknowledging contributors to your open source projects
https://allcontributors.org
MIT License
576 stars 150 forks source link

feat: parse github profile URLs #368

Closed Skn0tt closed 2 years ago

Skn0tt commented 3 years ago

Great work on all-contributors!

Sometimes, I'm lazy and I paste a URL like https://github.com/jakeBolam into a comment - I'd love if all-contributors supported that. This PR adds support.

vercel[bot] commented 3 years ago

@Skn0tt is attempting to deploy a commit to the All Contributors Team on Vercel.

A member of the Team first needs to authorize it.

gr2m commented 3 years ago

Hey Simon, thanks for the PR. I'd rather not merge it though, I'm trying to reduce complexity to make the app code easier to maintain, and the use case to parse URLs to GitHub user accounts instead of user names didn't come up before or after you created the PR. We can keep it open for a while, but unless there is more demand for it I'd rather close it.

Out of curiosity: where do you get the profile URL from, when asking the app to add someone as contributor?

Skn0tt commented 3 years ago

Hey @gr2m! I don't exactly remember where I got the profile URL, I think I accidentally hit Right-Click -> Copy Link on some contributor. When I pasted that into the field, my thoughts were "well, all-contributors seems to understand almost anything I give it - let's see if it also understands profile URLs!". And when it didn't, I quickly put together this PR :) Keeping complexity low is important, I'm absolutely with you. I like the idea of keeping it open a bit longer - but absolutely feel free to close the PR in a couple weeks :)

tenshiAMD commented 2 years ago

I'm absolutely with you. I like the idea of keeping it open a bit longer - but absolutely feel free to close the PR in a couple weeks :)

Closing this one since agreed by the author @Skn0tt and reviewer @gr2m.