search

all-contributors / app

🤖 A GitHub App to automate acknowledging contributors to your open source projects
https://allcontributors.org
MIT License
576 stars 150 forks source link

Contribution already registered even if PR is not merged #370

Closed brosaplanella closed 2 years ago

brosaplanella commented 3 years ago

Describe the bug If the bot is asked to add a contributor for a given contribution and the PR is not merged, when asked again to add that contribution the bot replies that the user has already contributed before to that aspect. Might it be because the bot is checking the existing contribution against an internal log rather than against all-contributorssrc?

To Reproduce Steps to reproduce the behavior:

  1. Ask the bot to add a contribution to a user.
  2. Close the resulting PR without merging
  3. Ask the bot again to add the contribution
  4. See error

Expected behavior The bot should open a new PR for that contribution.

arktn commented 2 years ago

Any fixes or workarounds for this?

tenshiAMD commented 2 years ago

@brosaplanella is this still relevant today? FYI, you need to delete the PR branch first. Let us know if this still occurs. Closing this for now. Thanks!

brosaplanella commented 2 years ago

I will have to check it when we encounter it again. If it happens, I will post it here. Thanks!