search

all-contributors / app

🤖 A GitHub App to automate acknowledging contributors to your open source projects
https://allcontributors.org
MIT License
576 stars 150 forks source link

Upgrade `compromise` to v13 #380

Open gr2m opened 3 years ago

gr2m commented 3 years ago

The all-contributors app currently depends on compromise v11. The latest version is v13. The upgrade is not straight forward and I'm not familiar with the package.

@Berkmann18 are you familiar with compromise? Could you help with the upgrade?

Berkmann18 commented 3 years ago

I've not dabbled with the latest release so I don't know if that would break the bot, it might be worth trying in a feature branch tho.

gr2m commented 3 years ago

when upgrading even from v11 to v12, the tests are starting to fail. We'll have to address that first, before testing it in a real app

Berkmann18 commented 3 years ago

Definitely, jumping straight to v13 would be risky. I recall having tried to upgrade the app to use a later major version and ended up leaving it in a stale branch where I jumped to v13 (and unsurprisingly the tests failed).